----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25524/#review53634 -----------------------------------------------------------
Ship it! Ship It! - Thejas Nair On Sept. 12, 2014, 3:22 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25524/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 3:22 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8047 > https://issues.apache.org/jira/browse/HIVE-8047 > > > Repository: hive-git > > > Description > ------- > > Update lazy char/varchar to support escape character > > > Diffs > ----- > > data/files/data_with_escape.txt PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > ql/src/test/queries/clientpositive/escape3.q PRE-CREATION > ql/src/test/results/clientpositive/escape3.q.out PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveChar.java ef469eb > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java > bc8d41e > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java 28b3f86 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1d62422 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java > 65fb1ab > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java > c802ed0 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java > 734b9d8 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveCharObjectInspector.java > c340dcb > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java > 7bbfd1f > > Diff: https://reviews.apache.org/r/25524/diff/ > > > Testing > ------- > > New q file test > > > Thanks, > > Jason Dere > >