----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25834/#review54107 -----------------------------------------------------------
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java <https://reviews.apache.org/r/25834/#comment94096> Shall we add a newline here? To make the coding style better. The patch looks good! I only have a very small comment here. - Dong Chen On Sept. 19, 2014, 5:28 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25834/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 5:28 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Allows either a file or dir. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a045b7 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 5231d5e > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > 5b1cbc0 > > Diff: https://reviews.apache.org/r/25834/diff/ > > > Testing > ------- > > > Thanks, > > Brock Noland > >
