[
https://issues.apache.org/jira/browse/HIVE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154230#comment-14154230
]
Gopal V commented on HIVE-8304:
-------------------------------
Patch LGTM, but it is confusing to read the
{code}
outputColumnVector.isNull[outputBatch.size] = true;
{code}
Because of ingrained assumptions that the size is one more than the actual data
size. Please leave a comment that after the copies into columns, the size is
incremented out of these loops.
> Tez Reduce-Side GROUP BY Vectorization doesn't copy NULL keys correctly
> -----------------------------------------------------------------------
>
> Key: HIVE-8304
> URL: https://issues.apache.org/jira/browse/HIVE-8304
> Project: Hive
> Issue Type: Bug
> Components: Tez, Vectorization
> Affects Versions: 0.14.0
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Fix For: 0.14.0
>
> Attachments: HIVE-8304.01.patch, HIVE-8304.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
