----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55378 -----------------------------------------------------------
bin/ext/hiveserver2.cmd <https://reviews.apache.org/r/26321/#comment95742> I don't think the "-hiveconf" paramaters should be part of the cmd. I see that you are trying to override the default value of some of these, but I think it is more appropriate to do that at the admin level (i.e. whichever admin service is managing the startup of hive). common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/26321/#comment95740> Can you add a description for this new param (for why this is required) ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java <https://reviews.apache.org/r/26321/#comment95741> Can you add a comment here explaining the intent of using HIVE_HADOOP_CLASSPATH? - Vaibhav Gumashta On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26321/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 6:27 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > On stopping the HS2 service from the services tab, it only kills the root > process and does not kill the child java process. As a result resources are > not freed and this throws an error on restarting from command line. > > > Diffs > ----- > > bin/ext/hiveserver2.cmd a5f3bb5 > bin/hive.cmd c2e9853 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 > > Diff: https://reviews.apache.org/r/26321/diff/ > > > Testing > ------- > > > Thanks, > > XIAOBING ZHOU > >
