-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26406/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5744
https://issues.apache.org/jira/browse/HIVE-5744
Repository: hive-git
Description
-------
Queries like
SELECT col1 BETWEEN 0 and 10 from T;
fail in vectorized mode. Support needs to be implemented for a BETWEEN
expression in the SELECT list, comparable to how it was added for comparison
operators (<, >, ...). These were done by adding new, templates that return a
value for a comparison instead of applying a filter. See
ColumnCompareScalar.txt under ql/src/gen for an example.
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 731b686
ql/src/gen/vectorization/ExpressionTemplates/ColumnBetween.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/FilterColumnBetween.txt e9aaaf2
ql/src/gen/vectorization/ExpressionTemplates/FilterDecimalColumnBetween.txt
829b9ca
ql/src/gen/vectorization/ExpressionTemplates/TruncStringColumnBetween.txt
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/Driver.java a105eca
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
34f5823
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalColumnBetween.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringColumnBetween.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java
d7ace6d
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 13d5255
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java af633cb
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java
9d9ee57
ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java 93981fa
ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 0eb7c5a
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorFilterOperator.java
24a52a6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
9e3628f
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java
92e5a06
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java
60e20a3
ql/src/test/queries/clientpositive/vector_between_in.q 1bc6611
ql/src/test/results/clientpositive/udf_between.q.out cb63d1c
ql/src/test/results/clientpositive/vector_between_in.q.out 631ac19
Diff: https://reviews.apache.org/r/26406/diff/
Testing
-------
Thanks,
Navis Ryu
