----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26209/#review55715 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java <https://reviews.apache.org/r/26209/#comment96101> whitespace; also elsewhere ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java <https://reviews.apache.org/r/26209/#comment96102> nit - can just be one line ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java <https://reviews.apache.org/r/26209/#comment96103> I think parent is always a projection, so it's SingleRel and there's only one input. Type can be made more specific all the way from introduceDerivedTable to here - Sergey Shelukhin On Oct. 6, 2014, 5:39 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26209/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 5:39 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > create a derived table with new proj and aggr to address it > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java > 3d90ae7 > ql/src/test/queries/clientpositive/cbo_correctness.q f7f0722 > ql/src/test/results/clientpositive/cbo_correctness.q.out 3335d4d > ql/src/test/results/clientpositive/tez/cbo_correctness.q.out 5920612 > > Diff: https://reviews.apache.org/r/26209/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >