[
https://issues.apache.org/jira/browse/HIVE-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168043#comment-14168043
]
Lars Francke commented on HIVE-8222:
------------------------------------
Great that you could take a look.
Regarding your comments:
# I looked at the original [review request|https://reviews.apache.org/r/25901]
for guidance on which files where touched by CBO and looked at those. Within
the files that were only changed not added I did a git blame to see when the
lines were added/changed and the corresponding commits. So it should really
only be CBO code with one or minor two exceptions where I had to change
{{ArrayList}} to {{List}} to make everything work.
# Yes, I removed type casts but all of theme were explicit casts which weren't
needed
# I'll look at your Review Board comments and will go through the issues you
raised now.
I forgot to mention two things:
# There are lots of instances where object equality is used (e.g. {{obj1 ==
obj2}} instead of {{obj1.equals(obj2)}}). None of that was guarded by a
comment. I'd usually consider that a bug but maybe there's a reason behind it?
Especially with serializing/deserializing or with new code from someone who
doesn't realize this happens in a different part of the code this seems very
fragile (e.g. in {{HiveCost}})
# There are lots of unused method parameters, again I wasn't sure if this is by
intention or leftovers? (e.g. in {{PlanModifierForASTConv#fixTopOBSchema}} the
parameter {{rootRel}})
> CBO Trunk Merge: Fix Check Style issues
> ---------------------------------------
>
> Key: HIVE-8222
> URL: https://issues.apache.org/jira/browse/HIVE-8222
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Reporter: Laljo John Pullokkaran
> Assignee: Lars Francke
> Attachments: HIVE-8222.1.patch, HIVE-8222.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
