> On Oct. 15, 2014, 9:30 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 2710 > > <https://reviews.apache.org/r/26725/diff/1/?file=721247#file721247line2710> > > > > Since this fix relies on internal name, i am not sure if it will work > > for unaliased windowing functions. > > > > Try the following > > select key+value, *, rank().. ,key-value from t1;
it checks the same object that was created and put in the set against the set; note that it compares old column info (one of which is the one added for windowing). - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26725/#review56816 ----------------------------------------------------------- On Oct. 15, 2014, 1:34 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26725/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 1:34 a.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1eca13 > ql/src/test/queries/clientpositive/cbo_correctness.q a65d88a > ql/src/test/results/clientpositive/cbo_correctness.q.out f3f94fd > > Diff: https://reviews.apache.org/r/26725/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
