----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26844/#review57087 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java <https://reviews.apache.org/r/26844/#comment97571> we are in a zookeeper helper class. I think this variable name can be shortened to krbOptions or so service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/26844/#comment97573> i think this is long/complex enough for a separate function say setupZnodeAcls(conf, nodeAcls) the root acl and node acl values are same, lets use one variable (avoids repetition) service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/26844/#comment97572> Lets include the erroneous values in error message service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/26844/#comment97576> We should document the expected privileges of the root dir "/" or the HIVE_SERVER2_ZOOKEEPER_NAMESPACE if user chooses to pre-create it. - Thejas Nair On Oct. 16, 2014, 11:54 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26844/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 11:54 p.m.) > > > Review request for hive, dilli dorai, Eugene Koifman, and Thejas Nair. > > > Bugs: HIVE-8173 > https://issues.apache.org/jira/browse/HIVE-8173 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8173 > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/Utils.java 9b08fd9 > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java d9faa45 > service/src/java/org/apache/hive/service/server/HiveServer2.java 8691fcc > shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 3c7d2af > > shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > 6e1ad03 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 99a2bcf > > Diff: https://reviews.apache.org/r/26844/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >