----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26892/#review57248 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java <https://reviews.apache.org/r/26892/#comment97798> is "both are constants" valid case? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java <https://reviews.apache.org/r/26892/#comment97800> can bridge only be used for cast? - Sergey Shelukhin On Oct. 17, 2014, 9:38 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26892/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 9:38 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-8492 > https://issues.apache.org/jira/browse/HIVE-8492 > > > Repository: hive-git > > > Description > ------- > > Enhance Constant Folding to propagate constants for simple expressions > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > b1d2ba4 > ql/src/test/queries/clientpositive/constprog2.q 72ce5a3 > ql/src/test/results/clientpositive/constprog2.q.out 148d95b > > Diff: https://reviews.apache.org/r/26892/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Ashutosh Chauhan > >