> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > <https://reviews.apache.org/r/26854/diff/1/?file=723916#file723916line21> > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_functions' output > > Lefty Leverenz wrote: > Do you mean document in the wiki, or in javadocs? > > > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowFunctions > > Lefty Leverenz wrote: > Also > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+WindowingAndAnalytics. > > Thejas Nair wrote: > I mean the wiki docs. > You have very sharp eyes! I didn't think you would catch this review > comment :) > > Lefty Leverenz wrote: > <big grin> I'm so busy scanning email lists for doc issues, I don't have > time to fix the doc issues. > > Jason Dere wrote: > This was part of Navis' original changes .. hopefully he can explain why > this is necessary?
I see why it is needed, you can have a regular udf and windowing udf with same name. So we need a way to distinguish between them in 'show functions' output - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57232 ----------------------------------------------------------- On Oct. 20, 2014, 6:28 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 6:28 p.m.) > > > Review request for hive, Navis Ryu and Thejas Nair. > > > Bugs: HIVE-2573 > https://issues.apache.org/jira/browse/HIVE-2573 > > > Repository: hive-git > > > Description > ------- > > Small updates to Navis' changes: > - session registry doesn't lookup metastore for UDFs > - my feedback from Navis' original patch > - metastore udfs should not be considered native. This allows them to be > added/removed from registry > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 9ac540e > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 074255b > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b94f790 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java > 31f906a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > e43d39f > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 22e5b47 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java af633cb > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/MatchPath.java aa48a6c > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/Noop.java fcf6afd > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopStreaming.java 41e0102 > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMap.java 0b090a9 > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMapStreaming.java > 5d322d3 > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java > 903a9b0 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > 46f8052 > ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb > ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out > c7405ed > ql/src/test/results/clientnegative/create_function_nonudf_class.q.out > d0dd50a > ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5 > service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java > fd38907 > > Diff: https://reviews.apache.org/r/26854/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
