[
https://issues.apache.org/jira/browse/HIVE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180447#comment-14180447
]
Gunther Hagleitner commented on HIVE-8534:
------------------------------------------
Updated the review. Some smaller things. Have you considered adding a q file
test (end-to-end) for the whitelist, in addition to the junit test?
I still think the flat regex list would be simpler and more beneficial. In that
case, we'd create a hive-site file from it, which gives users a better idea of
what's happening - also they'd have a template for modifying it. You're hiding
the settings hard coded in the class file. That list or regex would also be the
single source of truth, without transformations or merging of lists.
On the other hand we can probably switch that at any time w/o much
compatibility overhead, so I think either way is better than what we have now.
+1
> sql std auth : update configuration whitelist for 0.14
> ------------------------------------------------------
>
> Key: HIVE-8534
> URL: https://issues.apache.org/jira/browse/HIVE-8534
> Project: Hive
> Issue Type: Bug
> Components: Authorization, SQLStandardAuthorization
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HIVE-8534.1.patch, HIVE-8534.2.patch, HIVE-8534.3.patch,
> HIVE-8534.4.patch
>
>
> New config parameters have been introduced in hive 0.14. SQL standard
> authorization needs to be updated to allow some new parameters to be set,
> when the authorization mode is enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
