-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25682/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 8:33 a.m.)
Review request for hive, Alan Gates, Navis Ryu, Prasad Mujumdar, and Sergey
Shelukhin.
Changes
-------
Patch 3 addresses Alan's comments and omits inessential changes (minor edits
and line breaks). HIVE-6586 has a list of changes and a generated template
file.
This patch is for branch-0.14 but when I named that as the base directory I got
an error, so I called the base directory "trunk" and then the upload worked.
The svn checkout was revision 1634265 but I left that out in the update process
because I thought it might have caused the error.
A separate patch will be available for trunk eventually. (Right now I can't
generate a template file in trunk due to a missing pom for
org.apache.hive:hive-shims:jar:0.15.0-SNAPSHOT.)
Bugs: HIVE-6586
https://issues.apache.org/jira/browse/HIVE-6586
Repository: hive
Description
-------
HIVE-6586 kept track of new configuration parameters and changes to parameter
descriptions when HIVE-6037 moved parameter descriptions into HiveConf.java
from hive-default.xml.template.
HIVE-6586.patch addresses all the fixes listed in the JIRA comments (except
ones that had already been fixed), tidies up some line breaks, and makes minor
edits to parameter descriptions. It also revises the descriptions of
hive.txn.xxx, hive.compactor.xxx, hive.server2.async.exec.shutdown.timeout, and
hive.security.authorization.createtable.owner.grants.
Patch 3: HIVE-6586.3.patch omits minor edits and most of the line break
changes, and addresses Alan Gates' review suggestions. For a complete list of
changed parameter descriptions and a generated hive-default.xml.template file
for patch 3, see the JIRA.
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1634265
Diff: https://reviews.apache.org/r/25682/diff/
Testing
-------
Generated hive-default.xml.template (attached to HIVE-6586) from the new
HiveConf.java and reviewed the changed parameter descriptions.
File Attachments
----------------
Patch 2, rebased and fixed some issues
https://reviews.apache.org/media/uploaded/files/2014/10/01/8e4b539e-2590-4d8e-b3b5-45175a051f9d__HIVE-6586.2.patch
Thanks,
Lefty Leverenz
