----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/#review58756 -----------------------------------------------------------
Thank Thejas for your patch. LGTM besides some minor issues. itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java <https://reviews.apache.org/r/27263/#comment99900> String variable TEST_NAME should be "testDSVOutput" itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java <https://reviews.apache.org/r/27263/#comment99901> TEST_NAME should be testTSV2Output instead. itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java <https://reviews.apache.org/r/27263/#comment99902> The same as above. ca - cheng xu On Oct. 28, 2014, 1:58 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27263/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 1:58 a.m.) > > > Review request for hive and Vaibhav Gumashta. > > > Bugs: HIVE-8615 > https://issues.apache.org/jira/browse/HIVE-8615 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8615 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 > > beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java > PRE-CREATION > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 6bbb046 > beeline/src/main/resources/BeeLine.properties d40c0dc > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 0947b8d > > Diff: https://reviews.apache.org/r/27263/diff/ > > > Testing > ------- > > tests added > > > Thanks, > > Thejas Nair > >
