[
https://issues.apache.org/jira/browse/HIVE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186490#comment-14186490
]
Vaibhav Gumashta commented on HIVE-8579:
----------------------------------------
+1
> Guaranteed NPE in DDLSemanticAnalyzer
> -------------------------------------
>
> Key: HIVE-8579
> URL: https://issues.apache.org/jira/browse/HIVE-8579
> Project: Hive
> Issue Type: Bug
> Reporter: Lars Francke
> Assignee: Jason Dere
> Attachments: HIVE-8579.1.patch, HIVE-8579.1.patch
>
>
> This was added by [~jdere] in HIVE-8411. I don't fully understand the code
> (i.e. what it means when desc is null) but I'm sure, Jason, you can fix it
> without much trouble?
> {code}
> if (desc == null ||
> !AlterTableDesc.doesAlterTableTypeSupportPartialPartitionSpec(desc.getOp())) {
> throw new SemanticException(
> ErrorMsg.ALTER_TABLE_TYPE_PARTIAL_PARTITION_SPEC_NO_SUPPORTED,
> desc.getOp().name());
> } else if (!conf.getBoolVar(HiveConf.ConfVars.DYNAMICPARTITIONING)) {
> throw new SemanticException(ErrorMsg.DYNAMIC_PARTITION_DISABLED);
> }
> {code}
> You check for whether {{desc}} is null but then use it to do {{desc.getOp()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
