----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27216/#review58905 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/27216/#comment100119> Fixing the description, adding example. shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java <https://reviews.apache.org/r/27216/#comment100102> The IDE removed the unnecessary cast. super.getSplits already returns a (InputSplit[]) shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java <https://reviews.apache.org/r/27216/#comment100074> The JAAS setting would be needed for reconnections, which will be done automatically by curator. There is only going to be one call to this per jvm. Only one instance of the tokenstore is used by both HS2 and metastore. Even if HS2 has embedded metastore, there will only be one instance of the token store, as embedded metastore does not use one. The init is also being called only once per object. - Thejas Nair On Oct. 28, 2014, 6:35 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27216/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 6:35 a.m.) > > > Review request for hive, Eugene Koifman and Vaibhav Gumashta. > > > Bugs: HIVE-8557 > https://issues.apache.org/jira/browse/HIVE-8557 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8557 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7d8e5bc > hcatalog/webhcat/svr/pom.xml 6065748 > > itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java > b81942a > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestDBTokenStore.java > 8860d30 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestZooKeeperTokenStore.java > 83a80b4 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 3cf43a9 > pom.xml c694980 > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java 11dd962 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java ab34d2d > service/src/java/org/apache/hive/service/server/HiveServer2.java 0aab3f9 > shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > d18ae44 > shims/common-secure/pom.xml 98b5ca1 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > 606f973 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java > 0bb2763 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java > f3c2e48 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java > 56735d8 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java > 9908aa4 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/TokenStoreDelegationTokenSecretManager.java > 4ccf895 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java > 8683496 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 9850405 > > shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java > d0d6c7b > > Diff: https://reviews.apache.org/r/27216/diff/ > > > Testing > ------- > > Existing tests excercised, manually tested in a cluster. > > > Thanks, > > Thejas Nair > >
