----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/#review59104 -----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/27362/#comment100421> we should set the default ACLProvider here (that returns nodeAcls), otherwise parent dirs will have all privs for everyone. service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/27362/#comment100419> we can remove the impl of ZooKeeperHiveHelper.createPathRecursively as well. service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/27362/#comment100422> do we need to create parents here ? service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/27362/#comment100420> a nit - remove the unnecessary () ? service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/27362/#comment100423> indentation seems off - Thejas Nair On Oct. 30, 2014, 12:01 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27362/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 12:01 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8664 > https://issues.apache.org/jira/browse/HIVE-8664 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8664 > > > Diffs > ----- > > jdbc/pom.xml 9a569d1 > jdbc/src/java/org/apache/hive/jdbc/Utils.java d53cde7 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 3e4f4e5 > pom.xml 69f4413 > service/pom.xml 9d47a69 > service/src/java/org/apache/hive/service/server/HiveServer2.java 0aab3f9 > > Diff: https://reviews.apache.org/r/27362/diff/ > > > Testing > ------- > > Manual testing with ZK. > > > Thanks, > > Vaibhav Gumashta > >
