> On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 1594 > > <https://reviews.apache.org/r/26854/diff/3-5/?file=729496#file729496line1594> > > > > Are these changes meant for this Jira? > > > > Hmm, I think I see why - have the persistent function lookups done > > during static initialization now caused the Hive class to not be > > instantiable during runtime? Could you try moving the persistent function > > lookups out of static initialization, and into a method, which gets called > > (but only initialized once) during SessionState.start()? Would that take > > care of the issue?
Hive.class is an access point to metastore, which should not be referenced from runtime classes like Table, Task, etc. Theses changes are for that. Decoupling persistent function registration code parts from static initializer seemed good idea. I'll try that. > On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java, > > line 134 > > <https://reviews.apache.org/r/26854/diff/3-5/?file=729506#file729506line134> > > > > What's the issue here? I tried but couldn't make run MR in hadoop-2. Any idea? > On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java, > > line 176 > > <https://reviews.apache.org/r/26854/diff/5/?file=745070#file745070line176> > > > > Is this change relevant to this Jira? Or is this just a general fix to > > TestJdbcWithMiniKdc.testNegativeTokenAuth, which I have noticed to be > > failing consistently in the precommit tests? This is my bad from HIVE-8186. Chainging error message will make this test pass, but HIVE-8481 would be better place to to. I'll removed this part. > On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java, > > line 144 > > <https://reviews.apache.org/r/26854/diff/5/?file=745071#file745071line144> > > > > Are the changes in this file meant for this Jira? This is called from static initializer in Hive(class). ObjectStore always returns collection but it's not true in this class. Can be fixed by checking null but seemed better to fix this for consistency. > On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java, line 399 > > <https://reviews.apache.org/r/26854/diff/5/?file=745080#file745080line399> > > > > Was this line meant to be in here? Yes, my bad. The remnant of futile attempts to run TestHiveServerSessions in hadoop-2. Will be removed. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review59281 ----------------------------------------------------------- On Oct. 30, 2014, 11:41 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 11:41 p.m.) > > > Review request for hive, Navis Ryu and Thejas Nair. > > > Bugs: HIVE-2573 > https://issues.apache.org/jira/browse/HIVE-2573 > > > Repository: hive-git > > > Description > ------- > > Small updates to Navis' changes: > - session registry doesn't lookup metastore for UDFs > - my feedback from Navis' original patch > - metastore udfs should not be considered native. This allows them to be > added/removed from registry > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9aa917c > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7d8e5bc > contrib/src/test/results/clientnegative/invalid_row_sequence.q.out 8f3c0b3 > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java > 6647ce5 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 88b0791 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 9ac540e > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 074255b > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e43a328 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bdeb92 > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 4e3df75 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java b900627 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 13277a9 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 211ab6c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java e2768ff > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java > 793f117 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 1796b7b > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 22e5b47 > ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 2b239ab > ql/src/java/org/apache/hadoop/hive/ql/session/SessionConf.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java af633cb > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > 46f8052 > ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb > ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out > c7405ed > ql/src/test/results/clientnegative/create_function_nonudf_class.q.out > d0dd50a > ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5 > ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787 > service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java > fd38907 > > Diff: https://reviews.apache.org/r/26854/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
