----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27421/#review59332 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java <https://reviews.apache.org/r/27421/#comment100606> Can this be private? ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java <https://reviews.apache.org/r/27421/#comment100604> Can this be static? - Xuefu Zhang On Oct. 31, 2014, 9:51 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27421/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 9:51 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8682 > https://issues.apache.org/jira/browse/HIVE-8682 > > > Repository: hive-git > > > Description > ------- > > enable CTAS table statistic collection on spark counter, and refactor > register spark counter code. > move related code from SparkUtilities to SparkTask as it's only used in > SparkTask, not common tool functions > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4a8ca47 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java b38ef7d > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java > cc8afa7 > ql/src/test/results/clientpositive/spark/ctas.q.out 158ec95 > > Diff: https://reviews.apache.org/r/27421/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
