----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27687/#review60210 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java <https://reviews.apache.org/r/27687/#comment101574> I don't feel we need to cache this, as this can change during a user session. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java <https://reviews.apache.org/r/27687/#comment101575> Can we document what are in the tuple, especially what each means? ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java <https://reviews.apache.org/r/27687/#comment101576> I'm not sure why this needs to be synchronized. Will this method be called by concurrent threads? It doesn't seem to be the case. - Xuefu Zhang On Nov. 6, 2014, 5:25 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27687/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:25 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8649 > https://issues.apache.org/jira/browse/HIVE-8649 > > > Repository: hive-git > > > Description > ------- > > First patch for HIVE-8649, to increase the number of reducers for spark based > on some info about the spark cluster. > We need to add a SparkListener to handle cluster status change if such events > are supported by spark. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java 5766787 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReducerParallelism.java > 2dbb5a3 > > Diff: https://reviews.apache.org/r/27687/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
