[ 
https://issues.apache.org/jira/browse/HIVE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202720#comment-14202720
 ] 

Gopal V commented on HIVE-8760:
-------------------------------

bq. It's faster if you run w/o ATSHook, because the clone only happens there. 
Cloning is fairly expensive.

+1 - this is a more contained fix for 0.14. This does not change any existing 
behaviour or API contracts.

This will not break outside of ATSHook, which we can disable in case it shows 
issues.

Copying always will be slow, but it runs the risk of changing the API contract 
strictness too late for 0.14. Badly written hooks might fail, if they use the 
common conf to pass variables between different hooks.

For a cleaner solution long-term (0.15+), I think we need a {{new 
HiveConf(conf).asReadonly()}}, to enforce the API contract for such badly 
behaving hooks.

> Pass a copy of HiveConf to hooks
> --------------------------------
>
>                 Key: HIVE-8760
>                 URL: https://issues.apache.org/jira/browse/HIVE-8760
>             Project: Hive
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 0.13.0, 0.14.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-8760.2.patch, HIVE-8760.patch
>
>
> because hadoop's {{Configuration}} is not thread-safe



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to