> On Nov. 10, 2014, 9:13 p.m., Brock Noland wrote: > > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 32 > > <https://reviews.apache.org/r/27566/diff/1/?file=748191#file748191line32> > > > > Is this new functionality?
In the previous code, it tried to use the ClassNameCompletor which is provided by the jline. In the latest version, we have to implement it by our own. - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review60674 ----------------------------------------------------------- On Nov. 4, 2014, 8:06 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27566/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 8:06 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-8609: move beeline to jline2 > The following will be changed: > * MultiCompletor-> AggregateCompleter > * SimpleCompletor->StringsCompleter > * Terminal.getTerminalWidth() -> Terminal.getWidth() > * Terminal is an interface now; -> use TerminalFactory to get instances of a > Terminal > * String -> CharSequence > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java > a9479d56a3dbb922e917762e25267999ff9277ae > beeline/src/java/org/apache/hive/beeline/BeeLine.java > 8539a415b288af0e8f7ee1056932e40c0155e1ea > beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java > 52313e6abc7974a9c2261063f19248f3293335d3 > beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java > c6bb4feb99f24074b69dff201b697ed2c1adeede > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java > f73fb445aeff0052f43179a2314f3f342f72ea5f > beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java > 3e88c531c761e9d42bc301fe1b4f1c22c5d0cbbd > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java > PRE-CREATION > beeline/src/java/org/apache/hive/beeline/CommandHandler.java > bab17789b8b9d97b98ee3b64efa10fef48260af4 > beeline/src/java/org/apache/hive/beeline/Commands.java > 7e366dc1d821a04d64f4e4923ebab2011e041a67 > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java > ab67700d3a83bc51902aa479f5f33ecb33401a47 > beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java > 2b957f20a63c17fd9decdfe4f2b2f92b30ecdb58 > beeline/src/java/org/apache/hive/beeline/SQLCompletor.java > 844b9ae313e5d4cb5680d55a90255418b84155f9 > beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java > bc0d9beb62ccbb0bff88d65e5e72d12c6f6bbb3b > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java > d7a9b0ea6730e06637ac5796f173a9f99ea054c3 > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java > 63668bca8a998c799002e0492866f80e0d730f0b > pom.xml a5f851f31df15660cebef0e4691ea34699c6d1ef > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java > 284acbc8ae70026ffb878de0f76921b4816737ba > > Diff: https://reviews.apache.org/r/27566/diff/ > > > Testing > ------- > > > Thanks, > > cheng xu > >
