> On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 57 > > <https://reviews.apache.org/r/27933/diff/1/?file=760615#file760615line57> > > > > Could we extend from HashTableSinkOperator instead? > > Jimmy Xiang wrote: > Probably we couldn't do that. We have some type issue. > HashTableSinkOperator extends TerminalOperator<HashTableSinkDesc> instead. > > Xuefu Zhang wrote: > You can change definition for HashTableSinkOperator as: > > public class HashTableSinkOperator<T extends HashTableSinkDesc> extends > TerminalOperator<HashTableSinkDesc> implements Serializable; > > Then, you can extend SparkHashTableSinkOperator from it: > > public class SparkHashTableSinkOperator extends > HashTableSinkOperator<SparkHashTableSinkDesc>; > > Given the amount of code duplication, I think this is worth it.
Ok, will do that. Also need to make some private members in HashTableSinkOperator protected. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61102 ----------------------------------------------------------- On Nov. 12, 2014, 11:58 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27933/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 11:58 p.m.) > > > Review request for hive, Chao Sun, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-8810 > https://issues.apache.org/jira/browse/HIVE-8810 > > > Repository: hive-git > > > Description > ------- > > Fixed the Spark HashTableSinkOperator > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > 78d9012 > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java f1c3564 > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java > a58a6c5 > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkHashTableSinkDesc.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27933/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
