Just to be clear and fair: I don't want us to get hung up about it. If it's 100, then that's it. However, the code was previously formatted at 110 and so we're going to see a tremendous amount of split lines and ugly stuff showing up.
This argument about side-by-side viewing... I can't recall the last time I put code side-by-side and certainly not on a single monitor. Where does it come from anyway? Cheers, Matt On Wed, Nov 4, 2020 at 1:39 PM Mahendran Mookkiah < [email protected]> wrote: > Hi Matt, > > Yes, we can put the code formatting on hold until we come to a conclusion. > I am still hesitating to make PR on a few other modules as breaking at > 100th char without refactoring is making it look bad. So thank you very > much for bringing this topic for discussion. > > All, > > With due respect, > > When I search apache java coding guide for standards > <https://www.google.com/search?q=apache+java+coding+guide+for+standards>, > I see various Apache projects maintain a page for coding standards. > Not sure whether these are uptodate or being maintained. I prefer to > follow some widely accepted standard and mention it in the contributing.md > file. > > The moment we introduce custom coding standard, we need to > > - maintain a page explaining custom rules. > - introduce new rules xml and make it part of repo. > - adopt it in build automation. > > I agree with Matt that the 100 character in line limit does not make sense > while we have big displays. > I wonder why google > As this is more of a developer preference kind it is hard to get everyone > to agree to it. > > Today I learned something new while learning about line limit > > - One blogger compares code reading with news paper columns explaining > why the columns are shorter. > - Another blog highlights about viewing the source on a smaller > display (phone/tablet). This opens my mind as I click the link to PR from > my phone to review the changes. (Please try it out) > - I have a 27 inch monitor when I open two files side by side, I see > it takes around 100 characters per line. Please see the screenshot (Notice: > I closed my side navigator which I don't normally close) > > [image: image.png] > > Either we decide to define a custom coding standard or adopt one, I > support and am happy to help make it easy for new contributors. > We need to come up with a plan to have a coding standard without making > the codebase look bad after following the standards. > > Looking forward to learning more. > > Thanks, > Mahendran Mookkiah > > On Tue, Nov 3, 2020 at 4:00 PM Matt Casters <[email protected]> > wrote: > >> I noticed we started to format the code. However, it's doing really weird >> things, splitting lines and so on. Can we please put this on hold for a >> while until we can evaluate this properly? >> >> Splitting lines at 100 for example is going to really do a number on the >> codebase. >> I thought we all collectively bought decent displays ;-) >> >> Cheers, >> Matt >> > -- Neo4j Chief Solutions Architect *✉ *[email protected] ☎ +32486972937
