mookkiah opened a new pull request #401: URL: https://github.com/apache/incubator-hop/pull/401
After the [discussion](https://chat.project-hop.org/hop/pl/edcg4f7s4iypzq9t3cwxgb55zo), Created new constant interface which holds only i18n message related strings. Choosing the package where BaseMessage is present which is being accessed in almost all UI classes. Not comfortable choosing enum for this case as I don't see option to keep he enum like below and use `.name()` or `.value()` to get the actual string public static final String SYSTEM_COMBO_YES = "SYSTEM_COMBO_YES"; or SYSTEM_COMBO_YES("System.Combo.Yes"); or SYSTEM_COMBO_YES("SYSTEM_COMBO_YES"); After reviewing, we can choose the best option and fix all the [sonarqube issues](https://sonarcloud.io/project/issues?id=hop&issues=AXMjPuw3tNti-jTiWHbA&open=AXMjPuw3tNti-jTiWHbA) reporting the same string and other similar strings. Signed-off-by: Mahendran Mookkiah <[email protected]> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
