HiromuHota commented on pull request #522:
URL: https://github.com/apache/incubator-hop/pull/522#issuecomment-753510644
@hansva Thanks for asking. I quickly checked the `getId()` and turned out it
is safe remove these as it internally calls `getInstance()`.
```
public static String getId() {
return getInstance().id;
}
```
Having said, `getId()` does not have to be static in the first place as it
internally calls each instance after all.
@mookkiah Alternatively we can modify it as follows:
```
public String getId() {
return id;
}
```
This is cleaner and semantically feels right, and would satisfy sonarqube.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
