mfgaspar commented on pull request #528:
URL: https://github.com/apache/incubator-hop/pull/528#issuecomment-753996410
The idea was to get the value directly from the Environment Variable if
defined instead of getting it from System Properties
System.getProperty vs System.getenv
But also good to have it from hop-config.json
To avoid System.getenv I could also do it similar to HOP_SHARED_JDBC_FOLDER
in the shell scripts
if [ -n "${HOP_PLUGIN_BASE_FOLDERS}" ]; then
HOP_OPTIONS="${HOP_OPTIONS}
-DHOP_PLUGIN_BASE_FOLDERS=${HOP_PLUGIN_BASE_FOLDERS}"
fi
How does that sounds ?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
