Hi Sergio, I am not sure if a user is waiting to see a samples project with a "transforms" folder and under that folder 300 sub directories each containing 1 or 2 pipelines. Adding the transform name to the .hpl file seems to be sufficient.
Cheers, Hans On Wed, Feb 3, 2021 at 9:36 AM Sergio Ramazzina (SERASOFT) < [email protected]> wrote: > Hi All, > > I'm also in favour of simplicity. Just an idea, would it be a good > thing, under the three main dirs Matt proposed, to keep files separated > by plugin name and eventually have a common directory to place all the > files needed by the samples to run properly? Having a set of > subdirectories named like plugin's name will prevent files to be > overwritten. > > Cheers > > Sergio > > Il 02/02/2021 22:51, Hans Van Akelyen ha scritto: > > Hi All, > > > > Totally agree that we should try and keep this as simple as possible. > > The naming convention you are suggesting is simple, I suggest we do the > > same for input files or special metadata objects that are needed. > > > > One thing to keep in mind is that the files with the same name will be > > overwritten, maybe we should see if we can make the build fail or add a > > check to our PR flow. > > The current PR flow does not go to the assembly phase so even if we make > > maven fail we will only see it in Jenkins > > > > Cheers, > > Hans > > > > On Tue, Feb 2, 2021 at 12:58 PM Matt Casters <[email protected] > .invalid> > > wrote: > > > >> Hi Hoppers, > >> > >> It took a bit to figure this out but PR 588 now includes an automatic > way > >> of picking up all 'src/main/samples' folders in the various plugins in > our > >> wonderful project. Thanks for the feedback so far. > >> > >> The 'samples' project is the companion of the 'default' project and is > >> pretty much coming along as discussed earlier. > >> > >> I wrote some docs > >> < > >> > https://github.com/apache/incubator-hop-docs/blob/cb83f1db498f26c6f93bd51dc25fc64948241a8f/hop-dev-manual/modules/ROOT/pages/plugin-samples.adoc > >> on how to include samples. (Please merge along with PR588) > >> > >> What is needed are suggestions as to how the folder structure should > look > >> like when all is said and done. I'm strongly in favor of keeping things > >> simple with the naming standard: > >> > >> Folders: > >> * transforms/ : transform examples > >> * actions/ : action examples > >> * beam/ : beam examples > >> > >> File naming: > >> <name of the transform/action> - <what it is demoed>.<hpl/hwf> > >> > >> If we could reach some sort of consensus I can add this to the > >> documentation. > >> Perhaps as a minimum we could have a note in the pipeline or workflow > >> describing what the sample in question does? Other ideas? > >> > >> Cheers, > >> Matt > >> > -- >
