Hi, No objection from my side.
Just a warning about activating spotless because we will have a lot of git diff at the first activation...
I had some bad feedback when using spotless in some projects. Regards, François On 19/04/2024 10:55, hans.van.akel...@gmail.com wrote:
Hi Hoppers, I am a bit in a spring cleanup mode, now that we have checkstyle included (with 1 rule but we'll get to more later) I would like to discuss adding spotless to our builds. Spotless allows us to pick a formatting style and automatically apply it when building the code. We can also add a check to our PR's to see if the code has been formatted properly. In the past we had decided to use the google formatter to format our code, and I think it is still mostly correct but as we were not enforcing it some drift has happened over the years. Different code styles by editors and personal preference makes PR review and validation harder as all code could get marked as changed due to formatting reasons. This could allow not so good actors to sneak in code changes we would not want. Let me know what you think, and if we agree I'll do the work. Cheers, Hans
