Hi All,

Created a PR, would be great if someone could check if this resolves all the 
issues:
https://github.com/apache/hop/pull/5612

Kr,
Hans
On 12 Aug 2025 at 09:18 +0200, Hans Van Akelyen <[email protected]>, 
wrote:
> I can see 2 potential issues on a re-run:
> 1) If the tab is active we are hitting this part of code 
> https://github.com/apache/hop/blob/167ed93e5af748c219d0b453a62d1afd42ff47f7/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/delegates/HopGuiPipelineGridDelegate.java#L123-L127
>
> I think startRefreshMetricsTimer() should be called here too
>
> The second bit is the actual timer itself. When execution a second time is 
> seems the pipeline is still in the isFinished() or isStopped() state. I am 
> guessing we are hitting this code before the states have been updated for the 
> re-run this is causing this block to trigger
> https://github.com/apache/hop/blob/167ed93e5af748c219d0b453a62d1afd42ff47f7/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/delegates/HopGuiPipelineGridDelegate.java#L277-L280
>
> And the timer will be stopped 1 second after start (this is why we are seeing 
> some metrics)
>
> Kr,
> Hans
> On 11 Aug 2025 at 21:20 +0200, Hans Van Akelyen <[email protected]>, 
> wrote:
> > Sounds like a reason to block this release and have this fixed first. Make 
> > sure to work from the release branch for the fix as the main branch has 
> > moved forward and we probably don’t want those changes yet. I’ll also take 
> > a look tomorrow to check what caused the regression.
> >
> > Kr,
> > Hans
> >
> > On Mon, 11 Aug 2025 at 19:51, Matt Casters <[email protected]> wrote:
> > > Hi Hans,
> > >
> > > Thanks again for building this release.  This RC1 builds and checks out
> > > fine but unfortunately I see a regression of issue #5475
> > > <https://github.com/apache/hop/issues/5475>.
> > > The pipeline metrics not updating was a real pain in 2.14.0, was fixed and
> > > somehow re-introduced in the last couple of weeks.
> > > I was on vacation last week but this week I have time to fix it if we're
> > > willing to roll an RC2.
> > >
> > > All the best,
> > > Matt
> > > ---
> > > Matt Casters <m <[email protected]>[email protected]>
> > > Senior Solution Architect
> > > Fonteinstraat 70, 9400 OKEGEM - Belgium
> > >
> > >
> > >
> > >
> > > Op vr 8 aug 2025 om 21:03 schreef David Campen 
> > > <[email protected]>:
> > >
> > > > Hans,
> > > >
> > > > Thanks for your work in building this release!
> > > > I followed the steps in the "Checking a release" guide and checked a
> > > > couple of workflows and pipelines without any issues.
> > > >
> > > > +1 (binding).
> > > >
> > > > Regards,
> > > > Dave Campen
> > > >
> > > >
> > > > > On Aug 8, 2025, at 7:36 AM, Hans Van Akelyen 
> > > > > <[email protected]>
> > > > wrote:
> > > > >
> > > > > Hi All,
> > > > >
> > > > > This is the first release in our new release schedule, the next 
> > > > > release
> > > > is planned for november.
> > > > >
> > > > > Notable changes in this release:
> > > > > New features:
> > > > >
> > > > > • Rounding types exposed in the metadata tab of select values
> > > > > • New location for execution information OpenSearch
> > > > > • Databricks Database dialect
> > > > > • Google sheet proxy support and sheet recreation
> > > > >
> > > > > Improvements:
> > > > >
> > > > > • Variable substitution in some new locations
> > > > > • Improvements around the unit testing features
> > > > > • A lot of documentation updates
> > > > >
> > > > > Fixes:
> > > > >
> > > > > • While fixing some thread leaking the refresh of logs and metrics got
> > > > broken, this should be resolved now
> > > > > • Saving files was sometimes flaky, this should be resolved
> > > > >
> > > > >
> > > > > Build instructions can be found in the README included.
> > > > >
> > > > > The tag to be voted on is 2.15.0-rc1 (commit 77e311f):
> > > > > https://github.com/apache/hop/tree/release/2.15.0
> > > > >
> > > > > The release files, including signatures, digests, etc. can be found 
> > > > > at:
> > > > > https://dist.apache.org/repos/dist/dev/hop/apache-hop-2.15.0-rc1/
> > > > >
> > > > > The SHA512 Checksum for these artifacts is:
> > > > > Source:
> > > > >
> > > > 909a1ec2d2aaea158b6659a1c12dc1a7ccb58ad09f254e1f28e36281ca5fa36544349d23d43d29bb3c846a0d6d3df654386bc761899031789af0bff34cb88621
> > > > > client:
> > > > >
> > > > ead7b0c72d678cad559c4b5a086338d2ac9ae3b67eb0de85186c8039ac4f417377223b51d70053341c696e1fb53f125579efa4c8fb4a49de593ae6ecfe1c430c
> > > > >
> > > > > Release artifacts are signed with the following key:
> > > > >
> > > > https://keyserver.ubuntu.com/pks/lookup?op=vindex&search=0x0afca1919d19daa60ab0bf94c4092203eb788658
> > > > >
> > > > > For more information about the contents of this release, see:
> > > > > https://github.com/apache/hop/milestone/16?closed=1
> > > > > or
> > > > > https://github.com/apache/hop/releases/tag/2.15.0-rc1
> > > > >
> > > > > Please vote on releasing this package as Apache Hop 2.15.0!
> > > > >
> > > > > The vote is open for 72 hours and passes if
> > > > > a majority of at least 3 +1 PMC votes are cast.
> > > > >
> > > > > [ ] +1 Release this package as Apache Hop 2.15.0
> > > > > [ ] +0 No opinion
> > > > > [ ] -1 Do not release this package because ...
> > > > >
> > > > > Best Regards,
> > > > > Hans
> > > >
> > > >

Reply via email to