I do not see these issues as blocking, but we probably should add a CHANGELOG and update it each release along with adding javadocs. We can create tickets and address these issues for the next release
-Jake On Fri, Jan 9, 2015 at 12:44 PM, Lewis John Mcgibbney < [email protected]> wrote: > If we can clarify if the issues are NOT blocking this RC progressing then I > am more than happy to vreview folks. > Please let me know, I was in the process of reviewing until this email came > in... and quite right too! Good catches and excellent points. > Thanks > lewis > > On Thu, Jan 8, 2015 at 6:29 PM, Nick Dimiduk <[email protected]> wrote: > > > I'm trying out this RC over in HBase code. We've broken API compatibility > > in at least two commits: > > > > HTRACE-1 changes the SpanReceiver interface. HBase was instantiating > > SpanReceivers itself and calling .configure(HTraceConfiguration) on each > > one. Looks like now the expectation is that SpanReceiver implementations > > provide a constructor that takes a single parameter of > HTraceConfiguration. > > > > HTRACE-16 refactors the TraceTree interface a good bit. The handy > > getRoots() method has been replaced with the less obvious > > getSpansByParent().find(Span.ROOT_SPAN_ID) and .getSpansByParentIdMap() > is > > also an invocation of getSpansByParent().find(). > > > > Neither of these changes are a big deal, but none of this code has > > javadocs, so it's not obvious how the contract changed. I had to look at > > diffs and tests to decipher the new usage. This means that a simple > > search/replace is not sufficient for existing users to upgrade. > > > > For reference, my patch is over on HBASE-12810. > > > > I don't think this is enough to sink the RC, but my understanding of the > > earlier discussion was that this release would be a simple search/replace > > kind of upgrade. We need to document these idiom changes for folks. > > > > -n > > > > On Thu, Jan 8, 2015 at 5:06 PM, Stack <[email protected]> wrote: > > > > > I've posted our sixth htrace-3.1.0 RC here: > > > > > > http://people.apache.org/~stack/htrace-3.1.0-incubatingRC5/ > > > > > > Maven artifacts are here: > > > > > > > > https://repository.apache.org/content/repositories/orgapachehtrace-1007 > > > > > > The main changes from RC5 are packaging fixups and licensing > attribution. > > > > > > The release is a src-only tarball for now. Later we can add binary > > bundles > > > to our release after we have better sense of what we as a project would > > > like to deliver. > > > > > > This release is mainly a change of packaging from org.htrace to > > > org.apache.htrace to suit our new home here in Apache Incubator but it > > does > > > also includes 34 resolved issues [1] including the beginnings of an > > htrace > > > daemon whose intent is to make it so there is a low barrier collecting > > > cluster traces as well as a new flume receiver. > > > > > > Beware that Apache Incubator, org.apache.htrace is not compatible with > > its > > > former self, org.htrace: the package name has changed but so has the > JSON > > > serialization format. > > > > > > Shall we make this release candidate our first incubator release? > > > > > > Lets keep the vote period short (We'll have to run another vote over in > > > incubator general after this one if I understand the process properly). > > > > > > Please vote +1/0/-1 by Monday, January 9th, 2015. > > > > > > Thanks, > > > St.Ack > > > > > > 1. > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC > > > > > > > > > -- > *Lewis* >
