On Wed, Sep 2, 2015 at 9:32 AM, Jake Farrell <[email protected]> wrote:
> mvnw looks to be gradle training wheels, not sure that its needed. perhaps > a dockerfile would help here and also give us a build env we could run > tests within jenkins/travis with, just a thought > > +1. Creating a docker build environment for Jenkins has been on our to-do list for a while. It would be a great contribution for someone. It seems like it would also help anyone who wanted to build the project as well. > On Wed, Sep 2, 2015 at 12:20 PM, Adrian Cole <[email protected]> > wrote: > > > What do you think about moving to maven wrapper (ex ./mvnw install as > > opposed to maven install). This sorts out the maven version issues by > > baking them into the wrapper. > > > > I can raise a patch if you think this would help. > > > Thanks for the offer, but I'm not sure this is a good direction for us to go in. If we start putting shell scripts and other wrappers around Maven, things get even more complex. I've been down the autotools / virtualenv road, and it's not pretty. I have a suspicion that we can make later versions of maven work if we fiddle with our pom.xml dependency lists a bit. best, Colin
