On Monday 27 August 2001 16:05, Brian Pane wrote:
> In mod_include's find_start_sequence function, there's some code that
> splits the current bucket if "ctx->bytes_parsed >= BYTE_COUNT_THRESHOLD."
>
> Can somebody explain the rationale for this? It seems redundant to be
> splitting the data into smaller chunks in a content filter; I'd expect
> mod_include to defer network block sizing to downstream filters. In the
> profile data I'm looking at currently, this check accounts for 35% of the
> total run time of find_start_sequence, so there's some performance to
> be gained if the "ctx->bytes_parsed >= BYTE_COUNT_THRESHOLD" check can
> be eliminated.
It is used to ensure that we don't buffer all the data in mod_include. It isn't
really done correctly though, because what we should be doing, is just continuing
to read as much data as possible, but as soon as we can't read something, send
what we have down the filter stack.
This variable, basically ensures we don't keep reading all the data until we
process the whole file, or reach the first tag.
Ryan
______________________________________________________________
Ryan Bloom [EMAIL PROTECTED]
Covalent Technologies [EMAIL PROTECTED]
--------------------------------------------------------------
