dean gaudet wrote:
[...]
>but still, does this really work? 'cause the time used is
>r->request_time, if a request takes longer than 14 seconds or so to
>generate/serve then the logger is going to be asking for timestamps which
>are dangerously close to your cache rollover. and since you can't
>update a cache entry atomically it's possible they'll see a partially
>updated entry, and get bogus results.
>
You're right; a request that takes almost exactly 15 seconds is
vulnerable to corrupt data. I have a fix, though, that doesn't
require either locking or a gettimeofday() call. I'll post an
updated patch once I finish testing it.
--Brian
