On Saturday 15 September 2001 08:24 pm, Brian Pane wrote: > Ryan Bloom wrote: > >On Saturday 15 September 2001 02:59 pm, [EMAIL PROTECTED] wrote: > >>In a message dated 01-09-15 17:23:07 EDT, you write: > >>>>[Light comes on] Ahhh... guess I should have looked more closely at > >>>> > >>> >mod_log_config and I would have realized that you can configure it to > >>> >write certain notes to the log file. Duh. My fault. > >>> > >>> Wasn't the concensus a while back that request_rec->notes should be > >>> removed, because the more efficient 'userdata' functions on r->pool > >>> had made the notes table obsolete? > >>> > >>> --Brian > >> > >>It was 'discussed' but never played out. > >> > >>I wouldn't say there was anything near a 'consensus' on > >>anything. Only a few people even responsed. > >> > >>FWIW: I think the 'notes' stuff should stay, for now anyway. > >>Any discussion of removing it ( at this time ) is going to > >>ignite the 'why don't we just get this Server finished first > >>so people can at least start using it' debate. > > > >Actually, a consensus was reached. I believe that we even tried to do > > that work, but it isn't as easy as it should be, because it is easy to > > merge a table, but hard to merge a hash. > > I decided to make another attempt at removing the notes table this > afternoon. > Here's the patch... > > --Brian I haven't had time to review the whole patch, but please do not place calls to functions inside of the macros to check the return code. I realize that it will always be safe for APR_SUCCESS, but it is not good coding style, and it encourages bad habits. Ryan ______________________________________________________________ Ryan Bloom [EMAIL PROTECTED] Covalent Technologies [EMAIL PROTECTED] --------------------------------------------------------------
