"Sander Striker" <[EMAIL PROTECTED]> writes:

> > From: [EMAIL PROTECTED]
> > [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick
> > Sent: 12 March 2002 13:56
> 
> > "Sander Striker" <[EMAIL PROTECTED]> writes:
> > 
> > > Jeff,
> > > 
> > > Does this resolve the issue you added the comment for?
> > 
> > no
> > 
> > 1) the strncpy() can go beyond the allocated storage for the buffer
> 
> How so?  I substract the taglen from the total buffer length before
> reading the file, so it should be ok to copy the tag to the end.

oops, I missed that line

> 
> > 2) no terminating '\0' for the copy of the tag, so strstr() can't work
> >    anyway 

moron alert (since it is guaranteed to find your tag, you don't need
the '\0')

> What am I missing?

nothing; I'll shut up now :)

if it works, commit it (but surely you didn't need me to say that :) )

-- 
Jeff Trawick | [EMAIL PROTECTED]
Born in Roswell... married an alien...

Reply via email to