There are two other places in mod_proxy the MIN macro gets used. Shouldn't those get cast to the desired return type as well?
This one's a time_t: proxy_cache.c line 1175 maxage = MIN(maxage_req, maxage_cresp); and this one's a size_t: proxy_util.c line 734 strncpy(valbuf, list, MIN(p-list, sizeof(valbuf)-1)); Chuck On Friday, April 19, 2002, at 02:07 PM, William A. Rowe, Jr. wrote: > At 10:03 AM 3/19/2002, you wrote: >> At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >> >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) >> > : warning C4018: '<' : signed/unsigned mismatch >> > >> > n = ap_bread(f, buf, MIN(buf_size, len - >> total_bytes_rcvd)); >> >> I had posted a patch regarding this a bit ago... Any feedback? I was >> not able to recreate the exact error messages locally on any of >> my machines, so I couldn't see if it solved the specific problem >> (without creating more :) ). > > Doh! MIN() is implemented in terms of a terniary, and those are very > broken in terms of the result type on win32. Casting the MIN() back to > the arg type of ap_bread() should be sufficient. > >
