Seems like the cast isn't necessary. There's also a potential
size mismatch between conn_bytes's declared apr_off_t (which
could be 64 bits). Is there any time that the zero wouldn't
fill the LHS?

-aaron

Index: server/scoreboard.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/scoreboard.c,v
retrieving revision 1.66
diff -u -u -r1.66 scoreboard.c
--- server/scoreboard.c 29 Mar 2002 14:33:50 -0000      1.66
+++ server/scoreboard.c 4 Apr 2002 02:01:32 -0000
@@ -432,8 +432,8 @@
                 ws->my_access_count = 0L;
                 ws->my_bytes_served = 0L;
             }
-            ws->conn_count = (unsigned short)0;
-            ws->conn_bytes = (unsigned long)0;
+            ws->conn_count = 0;
+            ws->conn_bytes = 0;
         }
         if (r) {
             conn_rec *c = r->connection;

Reply via email to