On Sun, 28 Apr 2002, Bill Stoddard wrote:
> I have no problem with using apr_palloc()/memset() in place of apr_pcalloc().
Do you have a problem with making apr_pcalloc() a macro?
> > > > + rv = apr_thread_mutex_unlock(queue_info->idlers_mutex);
> > > > + if (rv != APR_SUCCESS) {
> > > > + return rv;
> > > > + }
> > > > + return APR_SUCCESS;
> > > > +}
> > >
> > > As I said before, simply "return rv;" works here.
> > Yeah, but this is much more readable.
> I disagree. I would rather see "return rv".
FWIW, I also prefer return rv. Or even return apr_thread_mutex_unlock();.
--Cliff
--------------------------------------------------------------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
