FWIW, I prefer to use the apache version. It is a known and will behave the same on all platforms. Same argument for using PCRE vs native regex libraries. n
Bill ----- Original Message ----- From: <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, June 18, 2002 12:08 AM Subject: cvs commit: apache-1.3/src/os/win32 os.h > wrowe 2002/06/17 21:08:26 > > Modified: src/ap ap.dsp > src/os/win32 os.h > Log: > We are safe. We don't need this according to MSVC docs assertions. > > Revision Changes Path > 1.15 +0 -4 apache-1.3/src/ap/ap.dsp > > Index: ap.dsp > =================================================================== > RCS file: /home/cvs/apache-1.3/src/ap/ap.dsp,v > retrieving revision 1.14 > retrieving revision 1.15 > diff -u -r1.14 -r1.15 > --- ap.dsp 18 Jun 2002 02:30:01 -0000 1.14 > +++ ap.dsp 18 Jun 2002 04:08:26 -0000 1.15 > @@ -119,10 +119,6 @@ > > SOURCE=.\ap_snprintf.c > # End Source File > -# Begin Source File > - > -SOURCE=.\ap_strtol.c > -# End Source File > # End Group > # Begin Group "Header Files" > > > > > 1.45 +6 -0 apache-1.3/src/os/win32/os.h > > Index: os.h > =================================================================== > RCS file: /home/cvs/apache-1.3/src/os/win32/os.h,v > retrieving revision 1.44 > retrieving revision 1.45 > diff -u -r1.44 -r1.45 > --- os.h 13 Mar 2002 21:05:36 -0000 1.44 > +++ os.h 18 Jun 2002 04:08:26 -0000 1.45 > @@ -172,6 +172,12 @@ > #define NO_SLACK > #include <stddef.h> > > +/* MSVC asserts that strtol "errno is set to ERANGE > + * if overflow or underflow occurs" > + * Ergo we can use the library strtol safely. > + */ > +#define ap_strtol strtol > + > #define NO_OTHER_CHILD > #define NO_RELIABLE_PIPED_LOGS > > > > >
