> -----Original Message-----
> From: Bill Stoddard [mailto:[EMAIL PROTECTED]]
> Sent: Friday, December 20, 2002 9:39 AM
> To: [EMAIL PROTECTED]
> Subject: RE: SSL segfault on HEAD
>
>
>
> > > Sigh. Wonder if this is related to what FirstBill saw earlier today with
> > > the proxy? Seeing as nothing has changed in the buckets code any time
> > > recently... OHHHHHHHH WAIT, yes it has. Brian apparently committed a
> > > change to allocate the apr_bucket_brigade itself out of the brigade
> > > allocator.
> >
> > Revert Brian's patch to apr_brigade.c (attached) and the segfaults go away.
> > Interesting... I suspect this patch tickled a bug elsewhere in the code.
> >
> > Index: apr_brigade.c
>
> Humm, the apr_brigade_destroy calls in core_output_filter look
> suspect. Freeing
> storage pointed to by almost every other higher level routine in the
> call stack
> can't be a good thing. We get away with it when the brigade is
> allocated out of
> a pool but that still does not make it right.
>
> Bill
Yep, reapplying Brian's patch and applying this patch to core eliminates the
segfault. Of course now we have a memory leak :-)
Index: core.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/core.c,v
retrieving revision 1.226
diff -u -r1.226 core.c
--- core.c 9 Dec 2002 22:19:26 -0000 1.226
+++ core.c 20 Dec 2002 14:32:58 -0000
@@ -3998,7 +3998,7 @@
logio_add_bytes_out(c, bytes_sent);
}
- apr_brigade_destroy(b);
+ apr_brigade_cleanup(b);
/* drive cleanups for resources which were set aside
* this may occur before or after termination of the request which
