Roy T. Fielding wrote:
>> First, the NETWARE part has to be above your additions.
>
>
> The reason I put the NETWARE part below the first new code was because
> I assumed (perhaps incorrectly) that there was no way that Apache or
> library functions it called were going to mess with the value returned
> by WSAGetLastError(), but possibly they might mess with errno, so by
> setting errno right before calling ap_log_error() there wouldn't be any
> problems.
Doesn't a file write mess with WSAGetLastError? *shrug*
log_error_core uses a temp variable to save and restore errno, which
is why setting errno first is more reliable.
At any rate, that concern goes away with the last patch I posted.
Thanks for looking!
