* William A. Rowe, Jr. wrote: >>Looking through the bugreports and the problems we have... >>internal_fast_redirect saves some CPU cycles (I guess), but it's finally >>(currently) an unclean thing. > > This was (in 1.3) an unclean thing in mod_negotiation. Early in 2.0, > I significantly refactored it to assure we 'initialized things properly' > between subrequests and fast_internal_redirects. And finally, just > to ensure it was well tested, moved it into mod_dir and possibly > other places.
yeah, it was not meant as offense (you probably know that). But it seems the surrounding concepts are not good enough, e.g. treating the subrequest as assbackwards without a flag on purpose of the subrequest etc. (hmm. hard to describe) > Now if we cannot maintain that code, I strongly suggest we drop that > feature altogether in Apache 2.2 and revert it's use in mod_dir, and within > mod_negotiation for 2.0 and 1.3.28. I agree (though it hurts a bit). Can we maintain the code? I'd say yes - later, after clearing the environment. We should switch to normal redirects for now and try to break the problems down, and try to resolve them. I personally hope to find the peace next time to provide some more details of my thoughts... >>IMHO we should drop and discourage the usage fast_redirects until the >>concept (subreq/filters/data stream/redirects) has reached some more >>maturity. Normal internal_redirects may be (a bit) slower, but they are >>approved and work as expected, since they process a complete request. > > We must either ditch it or support it, all the way around. it's a long way to 2.2. Until then it's beta software, so I'd see it not soo strong. Before dropping the interface entirely let's try to fix it. (but workaround in stable branches, of course). nd -- Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook! Ook? Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook? Ook. Ook! Ook! Ook? Ook! Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook! Ook. Ook! Ook! Ook! Ook! Ook! Ook.
