Am Montag, 23. Juni 2003 19:02 schrieben Sie:
> On Mon, Jun 23, 2003 at 10:26:55AM +0200, Philipp Reisner wrote:
> > Am Montag, 23. Juni 2003 03:56 schrieb Jeff Trawick:
> > > (apologies for missing the right mail reference and nasty quoting...
> > > e-mail problems, and luckily I was browsing the archives on daedalus
> > > during my ISP-imposed silence)
> > >
> > > Philip,
> > >
> > > Thanks for submitting the patch. I hope you will fix minor issues and
> > > resubmit for further review?
> >
> > Hi Jeff,
> >
> > Of course! I am happy that you are willing to help me to get it in.
> >
> > Please find the new version of the patch attached.
> >
> > BTW, Please have a close look to the part where I look at the
> > "Content-Type" header. The old code examien r->content_type. I had to
> > find an other way, one that is also possible for request filtering...
>
> You removed
> - apr_bucket_brigade *bb;
> so the later
> APR_BRIGADE_INSERT_TAIL(bb, b);
> is going to fail, won't it?
>
> Cheers,
> Glenn
>
>
> @@ -658,7 +662,6 @@
> apr_size_t len;
> char buf[4096];
> apr_status_t rv;
> - apr_bucket_brigade *bb;
> apr_bucket *b;
>
> while (1) {
> @@ -675,14 +678,9 @@
> if (rv != APR_SUCCESS) {
> return rv;
> }
> - bb = apr_brigade_create(r->pool, c->bucket_alloc);
> - b = apr_bucket_transient_create(buf, len, c->bucket_alloc);
> + b = apr_bucket_heap_create(buf, len, NULL, c->bucket_alloc);
> APR_BRIGADE_INSERT_TAIL(bb, b);
> - if ((rv = ap_pass_brigade(f->next, bb)) != APR_SUCCESS) {
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
> - "ap_pass_brigade()");
> - return rv;
> - }
> + return APR_SUCCESS;
> }
> /* we should never get here; if we do, a bogus error message would be
> * the least of our problems
Have a look at the chunk before, there the function gets a new parameter
called "bb".
-Philipp
--
: Dipl-Ing Philipp Reisner Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria http://www.linbit.com :
