I don't understand why ap_mpm_set_pidfile checks GLOBAL_ONLY
and cmd->server->is_virtual.
Checking cmd->server->is_virtual is enough.
If you want to maintain consistency with the other functions, then flip the
deletion to remove the check of ->is_virtual
Aryeh
# diff -u mpm_common.old.c mpm_common.c
--- mpm_common.old.c Thu Jul 24 15:16:10 2003
+++ mpm_common.c Thu Jul 24 15:16:09 2003
@@ -571,11 +571,6 @@
const char *ap_mpm_set_pidfile(cmd_parms *cmd, void *dummy,
const char *arg)
{
- const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY);
- if (err != NULL) {
- return err;
- }
-
if (cmd->server->is_virtual) {
return "PidFile directive not allowed in <VirtualHost>";
}
---
Aryeh Katz
Secured-Services Inc.