Re: 1.3.29... ? :)

[Glenn]

On Mon, Oct 13, 2003 at 02:03:37PM -0400, Jim Jagielski wrote:
> I'm looking to release 1.3.29 "soonish"... I think
> it's likely a good time to get another release
> out.
> 
> Fair warning :)

-1  (from non-commiter)
unless src/main/alloc.c was modified to better handle process cleanups
when used with suEXEC.  A few weeks ago, I downloaded 1.3.28 from Apache
(pristine source, not modified by any distributor) because I needed the
LimitInternalRecursion directive on one system.  CGI zombies started
piling up until I applied this custom patch, which works on RedHat 7.3
and should work on any POSIX system.

Cheers,
Glenn

diff -ru apache_1.3.28/src/main/alloc.c apache_1.3.28.new/src/main/alloc.c
--- apache_1.3.28/src/main/alloc.c      2003-06-20 11:05:40.000000000 -0400
+++ apache_1.3.28.new/src/main/alloc.c  2003-09-26 02:57:12.000000000 -0400
@@ -2860,7 +2860,9 @@
            || (p->kill_how == kill_only_once)) {
            /* Subprocess may be dead already.  Only need the timeout if not. */
            if (ap_os_kill(p->pid, SIGTERM) == -1) {
-                p->kill_how = kill_never;
+                if (errno != EPERM) {
+                    p->kill_how = kill_never;
+                }
             }
             else {
                need_timeout = 1;