Hi, So patched my httpd with Joe's patches and let it run overnight.
So good news is that these patches seem to solve the problem for the test cgi mentioned in the original PR (#23567). However, as soon as someone uses the "WinGet" download accelerator to download Mp3 files from my CGI prog (see PR 29528), httpd memory usage goes through the roof (90+MB resident per child). I don't have a windows machine here to reproduce. I'll try to do that later on today. Once again, this is with the prefork MPM on Linux. Also, I now see segfaults in the error log, which I never got before: [Wed Jun 16 03:48:48 2004] [notice] child pid 3609 exit signal Segmentation fault (11) [Wed Jun 16 04:19:40 2004] [notice] child pid 3603 exit signal Segmentation fault (11) [Wed Jun 16 04:28:54 2004] [notice] child pid 3606 exit signal Segmentation fault (11) The original PRs are at: http://issues.apache.org/bugzilla/show_bug.cgi?id=23567 and http://nagoya.apache.org/bugzilla/show_bug.cgi?id=29528 Cheers, -m On Tue, Jun 15, 2004 at 07:59:18PM +0100, Joe Orton wrote: > On Tue, Jun 15, 2004 at 03:23:42PM +0100, Joe Orton wrote: > > http://issues.apache.org/bugzilla/show_bug.cgi?id=23567 > > OK, the issues I was having with using the bucket allocator to allocate > the brigade were just my own screwups. So, the patches needed to fix > this issue are attached: > > 1) re-use pool cleanup structures > 2) allocate brigade structures using the bucket allocator > > these combine to prevent unbounded memory consumption when using > apr_brigade_split() from an output filter. > > (2) means that use of a brigade after it has been destroyed will now > result in a segfault. The test suite catches a particularly nice place, > which leads to: > > 3) don't destroy the brigade being flushed in ap_filter_flush; pass down > a temporary brigade. > > (looks like mod_bucketeer is also screwed like this, still working on > that one) > > Comments? > > joe
