Re: [PATCH] Re: Seg fault: race conditions in mod_mem_cache.c

[Jean-Jacques Clar]

>>> [EMAIL PROTECTED] 09/10/04 7:33 PM >>> At 06:53 PM 9/10/2004, Jean-Jacques Clar wrote: >I replaced the cleanup field with a bit set in refcount.  This is >done to prevent race conditions when refcount is accessed on two >different threads/CPUS. > >+#define OBJECT_CLEANUP_BIT 0x00F00000 >0x00F00000 isn't a bit, it's 4 bits: 0x00100000 | 0x00200000 | >0x00400000 | 0x00800000 >Why would you not use something farther up, such as 0x40000000, for >the bit?  (I imagine 0x80000000 would cause problems if apr_atomic_t >isn't unsigned). my bet, this is a minor detail, thanks for pointing it out. +#define OBJECT_CLEANUP_BIT 0x00800000