On Fri, Oct 15, 2004 at 08:14:03PM -0600, Paul Querna wrote: > Glenn Strauss wrote: > >>On Fri, 15 Oct 2004, Luc Pardon wrote: > > What are the general requirements to getting a patch or module > >included in the contrib/ directory? And on that topic, what > >happened to http://www.apache.org/dist/httpd/contrib/ ? > > > > I think /contrib/ is dead. > > I would rather look at committing your patch to httpd CVS. > > I don't have any objections to it on a concept level, but I have not > reviewed your code in detail.
Thanks, Paul. I don't want to discourage Luc, but there's a steep uphill battle to getting anything into Apache 1.3. I've tried unsuccessfully in the past to get what amounts to a two-line addition to mod_log_config.c to add vhost information to the error log. Here's some of the history (all for a patch whose meat is 2 lines!): 2003-06-24 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=105649710514527&w=2 2003-07-08 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=105763930020467&w=2 2003-09-04 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=106268054016100&w=2 2003-10-13 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=106608066626342&w=2 http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=106609152403979&w=2 I have been using the current patch, attached below, in production for a very long time now. Luc, do you think the patch below might have a place in your modifications, possibly wrapped in an #ifdef so that it can be enabled or disabled at compile time? Cheers, Glenn # # http://www.gluelogic.com/code/ # diff -ruN apache_1.3.31/src/main/http_log.c apache_1.3.31-new/src/main/http_log.c --- apache_1.3.31/src/main/http_log.c 2004-02-16 17:29:33.000000000 -0500 +++ apache_1.3.31-new/src/main/http_log.c 2004-05-24 12:26:06.000000000 -0400 @@ -349,7 +349,8 @@ * first. -djg */ len += ap_snprintf(errstr + len, sizeof(errstr) - len, - "[client %s] ", r->connection->remote_ip); + "[client %s] [%s:%u] ", r->connection->remote_ip, + ap_get_server_name(r), ap_get_server_port(r)); } if (!(level & APLOG_NOERRNO) && (save_errno != 0)
