You are correct that a patch based on mod_authnz_ldap.c won't apply cleanly to mod_auth_ldap.c because of various differences in the code base. But the patch is fairly self-contained meaning that the same chunk of code can easily be copied from mod_authnz_ldap.c and pasted into mod_auth_ldap.c without modification to the code snipet itself. I can certainly create and post an actual patch file that will apply cleanly to mod_auth_ldap.c if required. But it shouldn't be difficult to review the patch as it stands in mod_authnz_ldap.c.
Brad >>> [EMAIL PROTECTED] Wednesday, November 03, 2004 4:01:07 PM >>> On Wed, Nov 03, 2004 at 10:16:55PM -0000, [EMAIL PROTECTED] wrote: ... > + *) mod_authnz_ldap: Added the directive "Requires ldap-attribute" that > + allows the module to only authorize a user if the attribute value > + specified matches the value of the user object. PR 31913 > + modules/aaa/mod_authnz_ldap.c: r1.7 > + docs/manual/mod/mod_authnz_ldap.xml: r1.3 > + +1: bnicholes mod_authnz_ldap doesn't exist in 2.0; would this diff actually apply to mod_auth_ldap? If not then a separate patch needs to be posted somewhere for review. joe
